Repository navigation
Fix main CI: NextStep action optional for desktop UI build - #27
Merged
Merged
Conversation
Desktop CI failed on main because RolesPage and SearchPage use NextStep without an action; prepare:build runs tsc -b which requires it. Co-authored-by: Damon van der linde <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main CI failed after merging #26. All three desktop matrix jobs (
ubuntu/macos/windows) died intauri-action→prepare:build→@prm/uitsc -b:RolesPage.tsx:NextStepmissing requiredactionSearchPage.tsx: sameUbuntu unit tests were green; only the desktop UI production build typechecks failed.
Fix
Make
NextStep’sactionprop optional and skip rendering the action slot when omitted (informational callouts don’t need a button).Verify
pnpm --filter @prm/ui buildlocallymain